Wrong Map ID in the SQL

[Killyana]

I parsed a sniff and the mapID returned in the sql was wrong for spawns ( 0 instead of 571):

(@CGUID+137, 30273, 0, 210, 4504, 1, 1, 0, 0, 0, 6347.772, 225.4826, 393.7119, 1.151917, 120, 10, 0, 0, 0, 1, 0, 0, 0, 12340), -- 30273 (Area: 4504 - Difficulty: 0) (possible waypoints or random movement)
(@OGUID+38, 192965, 0, 210, 4504, 1, 135, 0, 6392.244, 440.5654, 511.2919, -0.1027641, -0.105731, -0.06836033, -0.05852318, 0.9903145, 120, 255, 1, 12340), -- 192965 (Area: 4504 - Difficulty: 0)

Area and zone ID are correct

[mdX7]

Which patch or build does the sniff have?

[Killyana]

3.3.5 12340 build

[mdX7]

bad news - mapid was added in 4.0.1 to updateobject, so we gotta hack a bit around to retrieve the map id. Like temporary saving the mapid after teleports and such.

WowPacketParser/WowPacketParser/Parsing/Parsers/UpdateHandler.cs

Lines 14 to 20 in 3b2e808

	[HasSniffData] // in ReadCreateObjectBlock
	[Parser(Opcode.SMSG_UPDATE_OBJECT)]
	public static void HandleUpdateObject(Packet packet)
	{
	uint map = MovementHandler.CurrentMapId;
	if (ClientVersion.AddedInVersion(ClientVersionBuild.V4_0_1_13164))
	map = packet.ReadUInt16("Map");

[Kittnz]

MapID is also broken in text output. It stays 0, confirmed with 1.13 sniffs.

[funjoker]

Classic also giving 0?
That's weird :/

[Shauren]

This might be the reason in pre-cata versions - CurrentMapId has ThreadStatic attribute so each thread has different value if you are using multithreaded parsing

WowPacketParser/WowPacketParser/Parsing/Parsers/MovementHandler.cs

Lines 15 to 16 in b223e9f

	[ThreadStatic]
	public static uint CurrentMapId;

[Kittnz]

I'm only using 1 thread, ofc i only tested 1.13 sniff

[Warpten]

It obviously won't work if you started sniffing after being in world and before being teleported

[Shauren]

1.13 is using bfa packets, that has mapid in UPDATE_OBJECT, it should output correctly

[Kittnz]

Map isn't read correctly at all.
Every map stays 0 unless you have specific targets.

[21:41:19] <Kittnz> ServerToClient: SMSG_SPELL_START (0x2C3A) Length: 95 ConnIdx: 1 Time: 11/21/2019 18:11:10.891 Number: 37981
[21:41:19] <Kittnz> (Cast) CasterGUID: Full: 0x0 Player/0 R4701/S0 Map: 0 Low: 12043035
[21:41:19] <Kittnz> (Cast) CasterUnit: Full: 0x0 Player/0 R4701/S0 Map: 0 Low: 12043035
[21:41:19] <Kittnz> (Cast) CastID: Full: 0x0 Cast/3 R4468/S146 Map: 1 Low: 39241009