Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix buffer overrun #10

Merged
merged 4 commits into from
Jun 8, 2023
Merged

fix buffer overrun #10

merged 4 commits into from
Jun 8, 2023

Conversation

myndcryme
Copy link
Collaborator

memset count parameter is incorrect and creates a buffer overrun. The array helper_data_new (size is 259) is memset with a count value of 296 (the size of the puf_binary_new array).

@myndcryme myndcryme added the bug Something isn't working label Jun 7, 2023
@myndcryme myndcryme requested a review from synctext June 7, 2023 20:27
@myndcryme myndcryme merged commit d434df7 into master Jun 8, 2023
@myndcryme myndcryme deleted the buffer_overrun_patch branch June 12, 2023 16:26
@myndcryme myndcryme linked an issue Jun 13, 2023 that may be closed by this pull request
Reconstruction of key is not working. #9
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synctext synctext Awaiting requested review from synctext

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconstruction of key is not working.
1 participant
@myndcryme