Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated IPv8 exit node script to use RustEndpoint #1266

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

egbertbouman
Copy link
Member

This PR does the following:

  • Enables RustEndpoint in the IPv8 exit node script. I haven't enabled it for all IPv8 nodes, as I don't think it makes sense since normal nodes will be making calls from within Python anyway (removing any chance of a performance improvement).
  • Add the ability for the TunnelCommunity to deal with DispatcherEndpoints.
  • Fixes a potential KeyError in relays_cell for rendezvous points.
  • Fixes an issue with leftover asyncio tasks after TunnelExitSocket removal.

I also fixed some issues with the CommunitySettings:

  • Fixes an issue with incorrect peer flags during the tunnel tests.
  • Fixes an issue with properties in CommunitySettings.
  • Fixes an issue with the default tunnel settings getting stored in overlay.settings.settings instead of in overlay.settings.

@egbertbouman
Copy link
Member Author

It looks like in cryptography 42.0 (released less than a day ago) the functions BN_clear_free/BN_clear/BN_zero aren't available anymore. So, I've removed BN_clear_free in favor of manually setting the BIGNUM to 0, followed by a call to BN_free. Not sure this is correct, but given that attestion logic isn't used anyway this seems OK.

@egbertbouman egbertbouman marked this pull request as ready for review January 23, 2024 15:44
@qstokkink qstokkink self-requested a review January 24, 2024 08:09
Copy link
Collaborator

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the attestation/identity scripts are somehow running an old version. I'll look at that later.

@egbertbouman egbertbouman merged commit eb7f2e5 into Tribler:master Jan 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants