Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp_apispec web.AppKey warnings #1242

Closed
qstokkink opened this issue Oct 23, 2023 · 3 comments
Closed

aiohttp_apispec web.AppKey warnings #1242

qstokkink opened this issue Oct 23, 2023 · 3 comments
Labels
priority: low Should be addressed at some point in the future

Comments

@qstokkink
Copy link
Collaborator

When running IPv8 or its unit tests, we get the following warning(s):

aiohttp_apispec/aiohttp_apispec.py:75: UserWarning: It is recommended to use web.AppKey instances for keys.
https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config
  app["_apispec_request_data_name"] = self._request_data_name
aiohttp_apispec/aiohttp_apispec.py:79: UserWarning: It is recommended to use web.AppKey instances for keys.
https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config
  app["_apispec_parser"] = parser
aiohttp_apispec/aiohttp_apispec.py:143: UserWarning: It is recommended to use web.AppKey instances for keys.
https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config
  app["swagger_dict"] = self.swagger_dict()

These warnings should be addressed in some way (by either adopting the advice or muting them).

@qstokkink qstokkink added the priority: low Should be addressed at some point in the future label Oct 23, 2023
@qstokkink
Copy link
Collaborator Author

Actually, these warnings have very little to do with our code: they are inside of our aiohttp_apispec dependency.

Upon further inspection, https://github.com/maximdanilchenko/aiohttp-apispec has not been updated in the last 10 months. The project might be dead. If so, it is unlikely that these warnings will be fixed.

For now, everything still works. However, this does not bode well and we should probably start thinking of a "Plan B". Just in case aiohttp_apispec does end up in disrepair.

@qstokkink
Copy link
Collaborator Author

If we end up having to switch, if seems like FastAPI offers roughly the same functionality that we use now.

@qstokkink
Copy link
Collaborator Author

I guess this can be closed. The policy, for now at least, is to just use this dependency until it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Should be addressed at some point in the future
Development

No branches or pull requests

1 participant