Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching for validate action dependencies #1237

Closed
qstokkink opened this issue Oct 19, 2023 · 1 comment · Fixed by #1260
Closed

Add caching for validate action dependencies #1237

qstokkink opened this issue Oct 19, 2023 · 1 comment · Fixed by #1260
Assignees
Labels
priority: low Should be addressed at some point in the future

Comments

@qstokkink
Copy link
Collaborator

qstokkink commented Oct 19, 2023

During the validation action we have two types of dependencies that are currently not being cached:

  • pip dependencies.
  • libsodium.dll only only on Windows (windows-latest).

Not caching these dependencies will not actively hurt our tests but slow them down and cause GitHub unnecessary traffic and diskio (rude).

@qstokkink qstokkink added the priority: low Should be addressed at some point in the future label Oct 19, 2023
@qstokkink
Copy link
Collaborator Author

Small update to the above: having to fetch libsodium.dll can actually hurt our tests.

Run python run_all_tests.py -a
Traceback (most recent call last):
Failed to locate libsodium (libnacl requirement), downloading latest dll!
  File "D:\a\py-ipv8\py-ipv8\run_all_tests.py", line 318, in <module>
    install_libsodium()
  File "D:\a\py-ipv8\py-ipv8\run_all_tests.py", line 266, in install_libsodium
    connection.request("GET", "/libsodium/releases/", headers={})
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\http\client.py", line 1283, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\http\client.py", line 1329, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\http\client.py", line 1278, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\http\client.py", line 1038, in _send_output
    self.send(msg)
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\http\client.py", line 976, in send
    self.connect()
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\http\client.py", line 1448, in connect
    super().connect()
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\http\client.py", line 942, in connect
    self.sock = self._create_connection(
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\socket.py", line 845, in create_connection
    raise err
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\socket.py", line 833, in create_connection
    sock.connect(sa)
TimeoutError: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond
Error: Process completed with exit code 1.

@qstokkink qstokkink self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Should be addressed at some point in the future
Development

Successfully merging a pull request may close this issue.

1 participant