Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong hypen location in GitHub validate PR action #1218

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Oct 12, 2023

Related to #1056

New error:

      - uses: actions/setup-python@v4
      - with:
          python-version: ${{ matrix.version }}
        run: python --version
>>
Invalid workflow file: .github/workflows/pr-comment-validate.yml#L18
The workflow is not valid. .github/workflows/pr-comment-validate.yml (Line: 18, Col: 9): Unexpected value 'run' .github/workflows/pr-comment-validate.yml (Line: 16, Col: 9): Required property is missing: uses

Previous error:

      - uses: actions/setup-python@v4
        with:
          python-version: ${{ matrix.version }}
        run: python --version
>>
Error: .github#L1
a step cannot have both the `uses` and `run` keys

This PR:

  • Fixed previous PR making the with of the uses a new step instead of the run (oops).

Documentation referenced: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#example-expanding-configurations

Note that this is PR 3/?, without any guarantees on the upper limit needed to get this running.

@qstokkink
Copy link
Collaborator Author

validate

@qstokkink qstokkink changed the title WIP: Activated validate action with real test command WIP: Fixed wrong hypen location in GitHub validate PR action Oct 12, 2023
@qstokkink qstokkink changed the title WIP: Fixed wrong hypen location in GitHub validate PR action READY: Fixed wrong hypen location in GitHub validate PR action Oct 12, 2023
@qstokkink qstokkink marked this pull request as ready for review October 12, 2023 06:56
@qstokkink qstokkink changed the title READY: Fixed wrong hypen location in GitHub validate PR action Fixed wrong hypen location in GitHub validate PR action Oct 12, 2023
@qstokkink qstokkink merged commit 1f7c91b into Tribler:master Oct 12, 2023
8 checks passed
@qstokkink qstokkink deleted the upd_validation_realv2 branch October 12, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants