bug: No message for new user about checking and verifying email

[introkun]

What version of MyFinances are you currently using?

v0.2.1

What device type are you currently facing the issue on?

Desktop

Describe the bug

Steps:

• create a new user with manual details (non-github/google)
  Actual result:
• login screen expecting user's email
• user is not able to log in (no error message in bug: No user-friendly message for users w/o verified email #245)

Expected result:

• user-friendly message to check the inbox and activate account by verifying email

[introkun]

Related to #245

[ssheth75]

I would like to work on this issue, thanks!

[kryptokun]

Same, we are working together so wanted to know if we both could be assigned?

[TreyWW]

Sure thing! Sorry I completely missed your messages.

[kryptokun]

I'm having trouble finding the code where the message for new user function is. Could I get some help locating it? I know that the functionality will occur in the login_initial.html

[TreyWW]

It's probably in backend/views/core/auth/login.py

[TreyWW]

Any progress @kryptokun?

[kryptokun]

Sorry was packed with a lot of school work. Will get on it this weekend

[TreyWW]

Amazing, no problem, just making sure you aren't stuck :)

[TreyWW]

Would you like to be unassigned from this issue @kryptokun?

[Domejko]

@TreyWW This issue is outdated since PR #270 have resolved that problem. Unfortunately latest PR #362 have broke that functionality since it wasn't caught in tests and I just discovered this while testing on server.

I will revert that change and this issue can be closed.

Edit:
Now I noticed that your latest commit have fixed that issue from #362 so I will just send update for type: ignore

One thing is that to have this functionality working we need to provide some testing random API key in .env, for example:

SENDGRID_API_KEY=asd87aFDASDFE*f7fsd86asHDZSDJHAs87212b121

I can update .env.sample with it if you like. Let me know, then I will send both changes in one PR.

[TreyWW]

Hmm since we've moved to SES for emails we've not continued support for Sendgrid. Maybe I should do a revamp for emails and allow for either to be used?

[Domejko]

I think that since it's open source project it will be good to have a choice.