Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request, Response, connection, sugars #10

Open
5 tasks
dangell7 opened this issue Aug 29, 2022 · 0 comments
Open
5 tasks

Request, Response, connection, sugars #10

dangell7 opened this issue Aug 29, 2022 · 0 comments
Labels
v1 Version 1 (XRPLF 1 to 1)

Comments

@dangell7
Copy link
Member

dangell7 commented Aug 29, 2022 •
edited
Loading

In the xrpl response the transaction is appended to the result. This functionality doesn't exist in the XRPLSwift sdk at the moment.

  • Transaction Models need to be agnostic and use dynamic T variable

XRPLSwift/Sources/XRPLSwift/Xrpl/Clients/RequestManager.swift

Line 190 in 618645d

if map.requestType.self is AccountChannelsRequest.Type {

Connection doesn't have the requestAll features.

Client: JS: https://github.com/XRPLF/xrpl.js/tree/main/packages/xrpl/src/client

  • RequestManager: Refactor Request/Response
  • connection: Add missing functions (RequestAll + Delegates)

Sugars are incomplete.

Sugars: JS: https://github.com/XRPLF/xrpl.js/tree/main/packages/xrpl/src/sugar

  • Balances
  • GetOrderBook
@dangell7 dangell7 added enhancement New feature or request v1 Version 1 (XRPLF 1 to 1) and removed enhancement New feature or request labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v1 Version 1 (XRPLF 1 to 1)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dangell7