Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify round-trip routes #5

Open
samcrawford opened this issue May 16, 2020 · 3 comments
Open

Simplify round-trip routes #5

samcrawford opened this issue May 16, 2020 · 3 comments

Comments

@samcrawford
Copy link
Contributor Author

Another possibility for the avoid repetition feature: right now, avoid repetition simply tries to avoid running on the same path twice. But there could be another path adjacent to the original one and it'd happily use that. Perhaps avoid repetition should set a distance buffer around the edges already visited and then avoid entering that buffer.

@samcrawford samcrawford added the in progress This issue is being actively worked on right now label May 22, 2020
@samcrawford
Copy link
Contributor Author

samcrawford commented May 22, 2020

Notes to self...

Main cause of lines crossing / complexity in routes is when routing around green polygons combined with the avoid repetition option.

Example: https://osm.trailrouter.com/#wps=51.45005,-0.07347%7C51.44806,-0.07755%7C51.44855,-0.08269%7C51.44615,-0.08282%7C51.44378,-0.07913%7C51.44440,-0.07512%7C51.44245,-0.07772%7C51.44145,-0.07034%7C51.44806,-0.07755%7C51.45005,-0.07347&ss=&rt=true&td=5000&aus=false&aus2=false&ah=false&ar=true&pga=true&im=false

Things to experiment with:

  • Simplify the green polygons. Convex hull is an option.
  • Turn off avoid repetition for polygons?
  • Improve avoid repetition to look for nearby edges, not just exact matches.
  • Turn off avoid repetition for the initial out-and-back to the green feature (first and last waypoint). Will be a nightmare to then edit routes afterwards.

While investigating, disable trail and water routes (done), disable fallback, disable duplicate removal and removal of routes that are too short/long

@samcrawford
Copy link
Contributor Author

samcrawford commented May 27, 2020

Some improvements made and released, but still lots to be done. Changes made:

  • Bugfix: Avoid Repetition does not consider the first and last edge in a segment.
  • Be more tolerant of low speed roads. We now do not penalise roads with <35km/h speed limits. Anything over that gets a heavy penalty still (unless it's specifically ok for foot traffic).

Convex hull work looked promising. Modifying avoid repetition to look for nearby edges is very inefficient, need to find a better way of handling this.

Putting back on hold for now.

@samcrawford samcrawford removed the in progress This issue is being actively worked on right now label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant