Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forkWithWebSocket #211

Open
samdoeswork opened this issue Aug 26, 2021 · 1 comment
Open

forkWithWebSocket #211

samdoeswork opened this issue Aug 26, 2021 · 1 comment

Comments

@samdoeswork
Copy link

Hi, I'm very interested in this library - but there's an issue.

We need the childprocess.fork method rather than childprocess.spawn, because we need the additional comms channel.

Looks like the newProcessWithWebSocketUrl would need to be replicated as newForkWithWebSocketUrl - replacing the execa call with a childprocess.fork call -- but I'm not sure how to do this while keeping all the other things intact.

Would you consider supporting fork?
@krisselden
Copy link
Collaborator

@samdoeswork sorry it took so long, I tried my best to make it so interfaces decoupled all the node specific things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krisselden @samdoeswork