Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jeeliz FaceFilter #3

Closed
xavierjs opened this issue Aug 27, 2020 · 2 comments
Closed

Update Jeeliz FaceFilter #3

xavierjs opened this issue Aug 27, 2020 · 2 comments

Comments

@xavierjs
Copy link

Hi,

I have pushed some major bugfixes on Jeeliz FaceFilter ( https://github.com/jeeliz/jeelizFaceFilter ) these last weeks.
There are some important compatibility improvements (related to jeeliz/jeelizFaceFilter#186 )
it would be worth updating :)

Best,
Xavier
@TowhidKashem
Copy link
Owner

Hey @xavierjs sorry for the late reply!

Ok so I thought this would be a simple update, I pulled the latest but doing so broke all the filters that I had pulled and modified from the demos. I guess there are some breaking changes there. I don't have the time to go through and update those right now so I think I'll skip the update for now.

@TowhidKashem
Copy link
Owner

@xavierjs I updated the lib to the latest (commit hash 06afda0ea88a0fe30ff43d586c89024795747caa). This time didn't encounter any issues with prior scripts breaking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TowhidKashem @xavierjs