fix(types/excelsheet): Fix duration to milliseconds conversion #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #159 Signed-off-by: Luka Peschke <[email protected]>
lukapeschke
added
bug
davinov
approved these changes
Jan 29, 2024
| @@ -5,7 +5,7 @@ | |||
| ruff = ruff python/ *.py | |||
| format = ruff format python/ *.py | |||
| mypy = mypy python/ *.py | |||
| pytest = pytest | |||
| pytest = pytest -v | |||
There was a problem hiding this comment.
I believe we do, without this pytest's assertion diffs are hard to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #159
For durations, we were using calamine's as_time API to convert durations to milliseconds, as the as_duration API was not available at the time of implementation. However, this does not work anymore, as as_time will return None for Duration values. This fixes it