Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing-extensions to dependencies #226

Closed
jlondonobo opened this issue Apr 5, 2024 · 2 comments
Closed

Add typing-extensions to dependencies #226

jlondonobo opened this issue Apr 5, 2024 · 2 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file 🐍 python 🐍 Pull requests that edit Python code

Comments

@jlondonobo
Copy link
Contributor

What's the issue?

fastexcel uses typing_extensions:

from typing_extensions import TypeAlias

However, typing_extensions is not part of dependencies in pyproject.toml

This causes a ModuleNotFoundError when fastexcel is installed by itself.

How to reproduce the bug?

  1. Create a virtual environment:
python -m venv .venv/
source .venv/bin/activate
  1. Install fastexcel:
pip install -e .
python
  1. Import fastexcel
import fastexcel

Error message

Python 3.12.2 (main, Feb 20 2024, 04:06:49) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import fastexcel
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/joselondono/Documents/forks/fastexcel/python/fastexcel/__init__.py", line 5, in <module>
    from typing_extensions import TypeAlias
ModuleNotFoundError: No module named 'typing_extensions'
@PrettyWood
Copy link
Member

Hello @jlondonobo
Thank you for the great report! You're absolutely right.

@lukapeschke lukapeschke added bug Something isn't working dependencies Pull requests that update a dependency file 🐍 python 🐍 Pull requests that edit Python code labels Apr 8, 2024
@PrettyWood
Copy link
Member

closed by #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file 🐍 python 🐍 Pull requests that edit Python code
Projects
None yet
Development

No branches or pull requests

3 participants