Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add default baseURL #24

Merged
merged 2 commits into from
Sep 2, 2024
Merged

chore: add default baseURL #24

merged 2 commits into from
Sep 2, 2024

Conversation

anonvt
Copy link
Contributor

@anonvt anonvt commented Sep 2, 2024

BaseURL is set as a var so we could test against our own mock server, but setting it as lateinit var overly complicates setup for customers for no actual gain.

  • Setup baseURL with the default public endpoint
  • Also removed the secondary bearer token location that was extant from a previous refactoring

@anonvt anonvt force-pushed the gui/chore/add-default-baseurl branch from a2e1e92 to 32241eb Compare September 2, 2024 18:39
@anonvt anonvt requested a review from fcs-ts September 2, 2024 18:48
@anonvt anonvt enabled auto-merge (squash) September 2, 2024 18:55
@anonvt anonvt merged commit 708a0ee into main Sep 2, 2024
2 checks passed
@anonvt anonvt deleted the gui/chore/add-default-baseurl branch September 2, 2024 18:58
@anonvt anonvt mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants