Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BannerView #21

Merged
merged 12 commits into from
Sep 16, 2024
Merged

feat: BannerView #21

merged 12 commits into from
Sep 16, 2024

Conversation

fcs-ts
Copy link
Contributor

@fcs-ts fcs-ts commented Aug 13, 2024

replaces #15

anonvt
anonvt approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@anonvt anonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Palbo's comment regarding some docs, LGTM

@PabloReszczynski
Copy link

Other than Palbo's comment regarding some docs, LGTM

Palbo

@fcs-ts
Copy link
Contributor Author

fcs-ts commented Aug 14, 2024

Palbo

Colo-Colo won a match yesterday, so I guess it's fitting

@PabloReszczynski
Copy link

@fcs-ts @anonvt what is missing for this to be merged?

@fcs-ts
Copy link
Contributor Author

fcs-ts commented Aug 30, 2024

what is missing for this to be merged?

@PabloReszczynski I had some trouble getting this to actually run auctions. I made some questions to @anonvt on how the new service handler should be setup (that we also want to have in the README/docs).

@anonvt
Copy link
Contributor

anonvt commented Sep 2, 2024 •
edited
Loading

Hopefully the issues with the ServiceSettings has been by #24
Otherwise LGTM

@fcs-ts
Copy link
Contributor Author

fcs-ts commented Sep 13, 2024

@PabloReszczynski Networking issues are fixed and I think I covered the docs
@anonvt When testing this I noticed a few issues when parsing the banner auctions responses, I would appreciate some review on these new changes :)

@fcs-ts fcs-ts enabled auto-merge (squash) September 13, 2024 20:46
@fcs-ts fcs-ts merged commit 0f9efd4 into main Sep 16, 2024
2 checks passed
@fcs-ts fcs-ts deleted the fcs/banner-view branch September 16, 2024 13:11
anonvt pushed a commit that referenced this pull request Oct 8, 2024
@fcs-ts @anonvt
feat: BannerView (#21)
7bbd3d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloReszczynski PabloReszczynski PabloReszczynski approved these changes

@anonvt anonvt Awaiting requested review from anonvt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fcs-ts @PabloReszczynski @anonvt