feat: add helpers to run banner auctions #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcs-ts
commented
Aug 9, 2024
TopsortAnalytics/src/main/java/com/topsort/analytics/banners/BannerConfig.kt
Outdated
Show resolved
Hide resolved
anonvt
approved these changes
Aug 9, 2024
|
This includes #15 correct? |
fcs-ts
force-pushed
the
fcs/banner-helpers
branch
from
337425b to
84a7c0b
Compare
TopsortAnalytics/src/main/java/com/topsort/analytics/banners/BannerConfig.kt
Show resolved
Hide resolved
PabloReszczynski
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow avoiding the creation of Auction objects manually, which gets a lot harder than for listings (although maybe we can do similar helpers for listings).
TODO:
appstarts to break with this changes (It seems they break even formainin my setup)