Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding custom user agent to config params #21

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

barbmarcio
Copy link
Contributor

@barbmarcio barbmarcio commented Jul 26, 2024

This PR is part of integrating Topsort.js with Analytics.js

This PR allows the SDK to receive custom User Agent as part of
identifying the version of Analytics.js being called for example.

@barbmarcio barbmarcio requested a review from jbergstroem July 26, 2024 11:42
sk-
sk- previously requested changes Jul 26, 2024
@barbmarcio barbmarcio requested a review from sk- July 26, 2024 22:35
Copy link
Member

@jbergstroem jbergstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should document this as well

@barbmarcio barbmarcio requested a review from jbergstroem July 29, 2024 16:42
@jbergstroem jbergstroem dismissed sk-’s stale review July 29, 2024 16:43

this has been fixed since

@barbmarcio barbmarcio merged commit 41978d5 into main Jul 29, 2024
5 checks passed
@barbmarcio barbmarcio deleted the feat/adding-custom-user-agent-to-headers branch July 29, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants