feat: use bun serve in http tests
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbmarcio
force-pushed
the
feat/e2e-tests-with-bun-serve
branch
3 times, most recently
from
d723049 to
d27996b
Compare
barbmarcio
force-pushed
the
feat/e2e-tests-with-bun-serve
branch
from
d27996b to
ee38a8d
Compare
jbergstroem
changed the title
bun serve in http tests
|
Question: why did you increase the retry? If this fails it'd be interesting to know why. |
Actually by default was set to 1. In order to test and not wait for the retries I've changed to 0, now just changing back to 1 :) |
jbergstroem
approved these changes
Jul 24, 2024
Agreed 100%, just changed it back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops a dependency and simplifies serving assets related to e2e tests.