Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional timeout to auction requests #11

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

PabloReszczynski
Copy link
Contributor

@PabloReszczynski PabloReszczynski commented Jul 17, 2024

Add an optional timeout option in the config to circuit break the auctions requests. Example:

try {
  await createAuction({ timeout: 50, apiKey }, auctions);
} catch (err) {
  console.error(err) // 'AbortError'
}

@jbergstroem
Copy link
Member

Can you add some documentation in the readme? Also, remove the update to the lockfile.

Copy link
Member

@jbergstroem jbergstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@barbmarcio when you find time, could you add an e2e test for this? Check this for reference: https://mswjs.io/docs/api/delay/

@PabloReszczynski PabloReszczynski merged commit db8be34 into main Aug 2, 2024
5 checks passed
@PabloReszczynski PabloReszczynski deleted the feat/p/auctions/timeout branch August 2, 2024 18:35
barbmarcio added a commit that referenced this pull request Aug 13, 2024
This PR adds an E2E test to simulate timeout being part of the config

Needs to be merged after
([#11](#11))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants