fix: add parameters as optional

Topsort · Aug 5, 2024 · 506655d · 506655d
1 parent d102429
commit 506655d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/types/auctions.d.ts b/src/types/auctions.d.ts
@@ -37,8 +37,8 @@ interface SponsoredListingAuction extends AuctionBase {
 
 interface BannerAuction extends AuctionBase {
   type: "banners";
-  device: DeviceType;
   slotId: string;
+  device?: DeviceType;
 }
 
 export interface TopsortAuction {

diff --git a/src/types/events.d.ts b/src/types/events.d.ts
@@ -1,27 +1,33 @@
 interface Placement {
   path: string;
+  position?: number;
+  page?: number;
+  pageSize?: number;
+  productId?: string;
+  categoryIds?: string[];
+  searchQuery?: string;
 }
 
 export interface Entity {
-  type: "product";
+  type: "product" | "vendor";
   id: string;
 }
 
 interface Impression {
-  resolvedBidId?: string;
-  entity?: Entity;
-  additionalAttribution?: Entity;
-  placement: Placement;
   occurredAt: string;
   opaqueUserId: string;
   id: string;
+  resolvedBidId?: string;
+  entity?: Entity;
+  additionalAttribution?: Entity;
+  placement?: Placement;
 }
 
 interface Click {
   resolvedBidId?: string;
   entity?: Entity;
   additionalAttribution?: Entity;
-  placement: Placement;
+  placement?: Placement;
   occurredAt: string;
   opaqueUserId: string;
   id: string;
@@ -31,6 +37,7 @@ interface Item {
   productId: string;
   quantity: number;
   unitPrice: number;
+  vendorId?: string;
 }
 
 interface Purchase {