Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the interface closer to the actual content of GCM notifications #144

Open
hypesystem opened this issue Jul 17, 2015 · 3 comments
Open
Milestone

Comments

@hypesystem
Copy link
Collaborator

Replace collapseKey with collapse_key, etc.

It would also be really cool if we could make it possible to send pre-built messages, for when the user knows what she is doing:

var gcm = require("gcm");
var sender = new gcm.Sender("<api key>");
sender.send({
    data: {
        hello: "world"
    }
}, "<registration id>", callback);
@hypesystem hypesystem added this to the v1 milestone Jul 17, 2015
@eladnava
Copy link
Collaborator

eladnava commented Dec 7, 2015

@hypesystem Would we provide the old keys as aliases for backward compatibility?

@hypesystem
Copy link
Collaborator Author

This PR has been marked with the v1 milestone (https://github.com/ToothlessGear/node-gcm/milestones/v1), becasue it contains breaking changes.

I use it to collect ideas for breaking changes that would make for a nicer interface. I don't think backwards compatibility should be a concern when we move to 1.0.0 --- learning from the experiences of pre-1.0 should be the prime concern 😄

@eladnava
Copy link
Collaborator

eladnava commented Dec 9, 2015

Cool. I definitely agree with making it possible to pass in properties the same way as with GCM (collapse_key for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants