Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone.js breaking in Safari 14 #25

Open
mklasinc opened this issue Oct 29, 2020 · 2 comments
Open

Tone.js breaking in Safari 14 #25

mklasinc opened this issue Oct 29, 2020 · 2 comments

Comments

@mklasinc
Copy link

I was using Tone v13.8.25 for a live project, and now I'm seeing that (only) in Safari 14 it breaks the site due to a reference error during mere import. Here's the error:
ReferenceError: Can't find variable: OscillatorNode

I also tested the Tone.js website (https://tonejs.github.io/) to see what happens with the latest version, and none of the examples run in Safari 14.
The error there:
ReferenceError: Can't find variable: BroadcastChannel

I'm now upgrading my project with the latest stable version, but just wanted to raise a flag that maybe even the latest version needs tweaking?

Safari: 14.0
Tone: 13.8.25 / 14.7.58

@tambien tambien transferred this issue from Tonejs/Tone.js Oct 29, 2020
@tambien
Copy link
Contributor

tambien commented Oct 29, 2020

This is actually an issue with the interactive example component, BroadcastChannel isn't used within Tone.js. so moving here as a reminder to take care of it.

@mklasinc
Copy link
Author

Ah cool! Yeah makes sense, I also found in the meantime that upgrading to latest version fixes the OscillatorNode reference error, so it's just the older versions that break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants