Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full source code of examples would be useful #1286

Open
benjaminbillet opened this issue Nov 1, 2024 · 0 comments
Open

Full source code of examples would be useful #1286

benjaminbillet opened this issue Nov 1, 2024 · 0 comments

Comments

@benjaminbillet
Copy link

benjaminbillet commented Nov 1, 2024

Hello!

Currently, the examples source code seems incomplete. If I take analysis.html it only shows how to instantiate things, but it's hard to understand what the function fft, waveform, etc. are doing because they are declared in a webpacked JS file. Is it intentional or am I missing a folder somewhere?

I think full examples like these are useful for learning purpose, by showing how the lib fit with other part of an application in practice. If I take analysis.html again, my intuition is that the "meat" of the example is not about calling the Tone.FFT constructor (the doc or the types are already very understandable), but more about how to handle the samples and visualize them. Questions like "is it better to do my own looping with requestAnimationFrame or does it make more sense to use a mix of Tone.Loop with Tone.Draw" would be naturally answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant