Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: showModulesWithMissingTraderLoyalty, showModulesWithMissingArea #19

Open
Solethia opened this issue Jul 12, 2024 · 2 comments · May be fixed by #20
Open

Feature Request: showModulesWithMissingTraderLoyalty, showModulesWithMissingArea #19

Solethia opened this issue Jul 12, 2024 · 2 comments · May be fixed by #20

Comments

@Solethia
Copy link

Problem

Current when disabling showFutureModulesLevels you still get requests for bitcoin farm, solar power, air filtering unit, gym and other modules that are not available yet and will not be for a while on a new account.

Suggestion

Add two new configs entries:
showModulesWithMissingTraderLoyalty that checks for ERequirementType.TraderUnlock and ERequirementType.TraderLoyalty.
showModulesWithMissingArea that checks for ERequirementType.Area
@Solethia
Copy link
Author

I can see there already is a PR for the ERequirementType.Area.
https://github.com/TommySoucy/MoreCheckmarks/pull/14/files

Solethia added a commit to Solethia/MoreCheckmarks that referenced this issue Jul 12, 2024
@Solethia
Issue TommySoucy#19: Feature Request: showModulesWithMissingTraderLoy…
6068b80 
…alty, showModulesWithMissingArea
Solethia added a commit to Solethia/MoreCheckmarks that referenced this issue Jul 12, 2024
@Solethia
Issue TommySoucy#19: Feature Request: showModulesWithMissingTraderLoy…
3a4c97b 
…alty, showModulesWithMissingArea
Solethia added a commit to Solethia/MoreCheckmarks that referenced this issue Jul 12, 2024
@Solethia
Issue TommySoucy#19 - Feature Request: showModulesWithMissingTraderLo…
d83bea7 
…yalty, showModulesWithMissingArea
@Solethia Solethia linked a pull request Jul 12, 2024 that will close this issue
Open
Solethia added a commit to Solethia/MoreCheckmarks that referenced this issue Jul 12, 2024
@Solethia
Issue TommySoucy#19 - Feature Request: showModulesWithMissingTraderLo…
2f56cc3 
…yalty, showModulesWithMissingArea
Solethia added a commit to Solethia/MoreCheckmarks that referenced this issue Jul 12, 2024
@Solethia
Issue TommySoucy#19 - Feature Request: showModulesWithMissingTraderLo…
ad6d316 
…yalty, showModulesWithMissingArea
Solethia added a commit to Solethia/MoreCheckmarks that referenced this issue Jul 12, 2024
@Solethia
Issue TommySoucy#19 - Feature Request: showModulesWithMissingTraderLo…
e8fa079 
…yalty, showModulesWithMissingArea
Solethia added a commit to Solethia/MoreCheckmarks that referenced this issue Jul 13, 2024
@Solethia
Issue TommySoucy#19 - Feature Request: showModulesWithMissingTraderLo…
388b7a4 
…yalty, showModulesWithMissingArea
@Solethia
Copy link
Author

I made my own PR that includes both settings in linked PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #19: Feature Request: showModulesWithMissing[...] Solethia/MoreCheckmarks
1 participant
@Solethia