Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #19: Feature Request: showModulesWithMissing[...] #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Solethia
Copy link

@Solethia Solethia commented Jul 12, 2024

  • Added showModulesWithMissingTraderLoyalty to config.
    • Checks for ERequirementType.TraderUnlock and ERequirementType.TraderLoyalty fulfillment when false.
  • Added showModulesWithMissingArea to config.
    • Checks for ERequirementType.Area fulfillment when false.

Closes #19

@Solethia
Copy link
Author

Solethia commented Jul 12, 2024

  • TODO: Test showModulesWithMissingTraderLoyalty
  • TODO: Test showModulesWithMissingArea
  • TODO: Update version number
  • TODO: Update readme with new config entries

@Solethia Solethia force-pushed the main branch 3 times, most recently from ad6d316 to e8fa079 Compare July 12, 2024 14:13
@Solethia
Copy link
Author

Solethia commented Jul 12, 2024

Standard Account Test

Config.json

{
	"fulfilledAnyCanBeUpgraded" : false,
	"questPriority" : 4,
	"hideoutPriority" : 3,
	"wishlistPriority" : 2,
	"barterPriority" : 0,
	"craftPriority" : 1,
	"showFutureModulesLevels" : false,
	"showModulesMissingArea" : false,
	"showModulesMissingTraderLoyalty": false,
	"showBarter" : false,
	"showCraft" : false,
	"showFutureCraft" : false,
	"needMoreColor" : [ 1,0.37255,0.37255 ], 
	"fulfilledColor" : [ 0.30588,1,0.27843 ], 
	"wishlistColor" : [ 0,0,1 ],
	"barterColor" : [ 1,0,1 ],
	"craftColor" : [ 0,1,1 ],
	"includeFutureQuests" : false
}

Expect all starter upgrades (vents, security, lavatory, heating, medstation, illumination) to appear on money, except stash as it requires vents lvl 1.

image
image
image

@Solethia
Copy link
Author

Solethia commented Jul 12, 2024

SptDev Account Test

Has all hideout upgrades, so expect nothing to show up.
image
image

@Solethia
Copy link
Author

Solethia commented Jul 12, 2024

EOD Account Test - Vents level 1 built

Expect stash not to appear on money.
image
image

@Solethia
Copy link
Author

Standard Account Test - Vents level 1 built

Expect stash to appear on money once vents are built.
image
image
image

@Solethia
Copy link
Author

Standard Account - Has trader level test (Workbench LVL 2 / Mechanic Level 2)

Given Illumination LVL 2 built
Given Workbench LVL 1 built
image

Given Mechanic Trader Loyalty is LVL 2
image

Expect Workbench LVL 2 items to be highlighted
image

@Solethia
Copy link
Author

Solethia commented Jul 13, 2024

Given Stash level 2
Given Heating level 2
Given Vents level 2
image
Given Prapor loyalty level 2
Given Jaeger loyalty level 2
image

Expect items for Stash level 3 to not be highlighted as it requires Prapor loyalty level 3 and Jaeger loyalty level 3.
image

@Solethia
Copy link
Author

Solethia commented Jul 13, 2024

Should be simple to add the same with other requirements in future if you want to remove items for modules locked by skills but I consider it out of scope for this feature for now.

Another side note is that turning them on and being blocked by area or loyalty level will prevent later module level items from being highlighted as well, similar to how the showFutureModulesLevels works when disabled. I consider this fine as when you turn these two new settings on that would be expected I believe.

@Solethia Solethia marked this pull request as ready for review July 13, 2024 15:01
@Solethia Solethia marked this pull request as draft July 13, 2024 15:04
@Solethia
Copy link
Author

Solethia commented Jul 13, 2024

After consideration of other people, will change the defaults to true, so if people copy in an old config without the two new settings in it, it will work as before. I assume they will be defaulted to true in the config that will be shipped with the dist .zip file as well, that way it is opt in.

@Solethia Solethia marked this pull request as ready for review July 13, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: showModulesWithMissingTraderLoyalty, showModulesWithMissingArea
1 participant