Merge branch 'ml/commit-graph-expire-dir-leak-fix'

gitster · gitster · commit 3239100b5a01 · 2022-09-21T14:23:14.000-07:00
A result from opendir() was leaking in the commit-graph expiration
codepath, which has been plugged.

* ml/commit-graph-expire-dir-leak-fix:
  commit-graph: Fix missing closedir in expire_commit_graphs
diff --git a/commit-graph.c b/commit-graph.c
@@ -2265,6 +2265,8 @@ static void expire_commit_graphs(struct write_commit_graph_context *ctx)
 	}
 
 out:
+	if(dir)
+		closedir(dir);
 	strbuf_release(&path);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2265,6 +2265,8 @@ static void expire_commit_graphs(struct write_commit_graph_context *ctx)`
`2265`	`2265`	`}`
`2266`	`2266`
`2267`	`2267`	`out:`
	`2268`	`+ if(dir)`
	`2269`	`+ closedir(dir);`
`2268`	`2270`	`strbuf_release(&path);`
`2269`	`2271`	`}`
`2270`	`2272`