Implement NGC save/load in hs-toxcore and run round-trip tests against c-toxcore #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

iphydf opened this issue Apr 18, 2022 · 2 comments

Milestone

Member

iphydf commented Apr 18, 2022

A new section type needs to be added and documented here: https://github.com/TokTok/hs-toxcore/blob/24ee6e2c3dc1d1565558c14705723228f5fdad6a/src/Network/Tox/SaveData.lhs#L116

Then it needs to be added and parsed here: https://github.com/TokTok/hs-toxcore/blob/24ee6e2c3dc1d1565558c14705723228f5fdad6a/src/Network/Tox/SaveData.lhs#L266

Then a test like this needs to be added: https://github.com/TokTok/hs-toxcore-c/blob/57d3c85f4042ea69c15916f58ebc5ec30a5af1ad/test/Network/Tox/Types/EventsSpec.hs#L59

And we should run that test against c-toxcore to make sure the documentation agrees with the implementation.

iphydf added this to the v0.2.19 milestone

Member Author

iphydf commented Nov 10, 2023

TokTok/hs-toxcore#218

iphydf added this to DHT Group Chats

iphydf moved this to In Progress in DHT Group Chats

Member Author

iphydf commented Dec 29, 2023

Mostly done. The rest just needs the save format to be made more msgpacky.

iphydf closed this as completed

github-project-automation bot moved this from In Progress to Done in DHT Group Chats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment