refactor: simplify if condition

christolis · christolis · commit 47cdcb254093 · 2024-03-20T11:29:17.000+02:00
diff --git a/application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java b/application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
@@ -61,7 +61,8 @@ public void onMessageReactionAdd(MessageReactionAddEvent event) {
             return;
         }
 
-        if (isCoolEmoji && originalReactionsCount + 1 >= config.minimumReactions()) {
+        final int newReactionsCount = originalReactionsCount + 1;
+        if (isCoolEmoji && newReactionsCount >= config.minimumReactions()) {
             event.retrieveMessage().queue(message -> {
                 message.addReaction(REACT_EMOJI).queue();
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,8 @@ public void onMessageReactionAdd(MessageReactionAddEvent event) {`
`61`	`61`	`return;`
`62`	`62`	`}`
`63`	`63`
`64`		`- if (isCoolEmoji && originalReactionsCount + 1 >= config.minimumReactions()) {`
	`64`	`+ final int newReactionsCount = originalReactionsCount + 1;`
	`65`	`+ if (isCoolEmoji && newReactionsCount >= config.minimumReactions()) {`
`65`	`66`	`event.retrieveMessage().queue(message -> {`
`66`	`67`	`message.addReaction(REACT_EMOJI).queue();`
`67`	`68`