Better block parameters?

[maxsupermanhd]

I was thinking about better way of storing block state information and I could not understand why can not it be a regular map[string]string. Also speaking of current implementation, it lacks method to get all the possible values of a field.

PS I am trying to reconstruct 3d model of things so I am digging into jar, blockstates, models and textures pretty hard here

[Tnze]

The current design is optimized for performance that block state serialization. The map is a horrible choice in this case. It takes a lot more memory but offers a very low operating speed. Regardless of heap memory allocation overhead, it cannot even be easily compared!

For example, how do you convert a map[string]interface{} as block state into state id? Take all properties, sort them by keys, calculate hash, then map them to state id? There is an implementation in here https://github.com/df-mc/dragonfly and you can take a look if you want.

[Tnze]

some descriptions only define some fields, others must be considered in all variations.

This can't be high performance, right? Can we avoid doing this at runtime?

[maxsupermanhd]

Yes, it will be done on init at worst, but it have to be prepared for every block state.
Rules are defining some blockstates, for example it can define facing but not power state that means you have to generate all blockstates with power state to be both on and off

[Tnze]

Can you traversal StateList and generate this mapping? Sounds like it's unnecessary to add them as Block's method now:)

[maxsupermanhd]

At this point I am doubting I will continue WebChunk development on the go-mc base because you have stuff changing all the time, I have finite resources afterall. Generating color palette is hard with block states being considered, I might ditch whole project because of that change. Today you have one thing tomorrow you will have another, I will better stick to old version of go-mc or move out completely to my own model just to simplify everything

[Tnze]

Yes, you have to make choices in development. Use go-mc or not. It depends on your needs.

I make choices too.