[BUG] Future grants to database roles are re-applied all the time

[mlavaert]

Something goes wrong fetching existing future grants to database roles. I've done a bit of debugging but failed to figure it out.

The problem starts here in data_provider.py in the fetch_future_grant function:

  grants = _filter_result(
      show_result,
      privilege=fqn.params["priv"],
      name=collection_str,
      grant_to=str(to_type),
      grantee_name=to,
  )

  if len(grants) == 0:
      return None
  elif len(grants) > 1:
      raise Exception(f"Found multiple future grants matching {fqn}")

str(to_type) will return DATABASE ROLE but the query in Snowflake uses DATABASE_ROLE in the result.
to uses the full FQN including the database name of the database role. Snowflake uses just the name of the database role.

[toadies]

I ended up updating my code to the following so I can proceed with my project.

Additional issue: grantee_name != value
Upon inspection, snowflake's role table only returns the database role name and does not include the database qualifier.

While reviewing fetch_future_grants, I noticed the process is fetching future grants by the to value, so no reason to match by grantee_name again.

grants = _filter_result(
        show_result,
        privilege=fqn.params["priv"],
        name=collection_str,
        grant_to=str(to_type).replace(" ", "_"),
        # grantee_name=to,
    )