precommit fixes

Author: measty

tiatoolbox/models/dataset/classification.py

@@ -322,7 +322,7 @@ def __init__(  # skipcq: PY-R1000  # noqa: PLR0915
             # mask on the fly
             try:
                 mask_reader = self.reader.tissue_mask(resolution=1.25, units="power")
-            except:
+            except ValueError:
                 # if power is None, try with mpp
                 mask_reader = self.reader.tissue_mask(resolution=6.0, units="mpp")
             # ? will this mess up  ?

tiatoolbox/visualization/bokeh_app/main.py

@@ -146,7 +146,7 @@ def get_channel_info() -> dict[str, tuple[int, int, int]]:
         resp = json.loads(resp.text)
         return resp.get("channels", {}), resp.get("active", [])
     except json.JSONDecodeError as e:
-        logger.warning(f"Error decoding JSON: {e}")
+        logger.warning("Error decoding JSON: %s", e)
         return {}, []
 
 
@@ -221,7 +221,11 @@ def create_channel_color_ui() -> Column:
 
     color_picker = ColorPicker(title="Channel Color", width=100)
 
-    def update_selected_color(attr: str, old: str, new: str) -> None:  # noqa: ARG001
+    def update_selected_color( # noqa: ARG001 # skipcq: PYL-W0613
+            attr: str, 
+            old: str, 
+            new: str
+            ) -> None:
         """Update the selected color in multichannel ui."""
         selected = color_source.selected.indices
         if selected:
@@ -243,7 +247,10 @@ def apply_changes() -> None:
 
     apply_button.on_click(apply_changes)
 
-    def update_color_picker(attr: str, old: str, new: str) -> None:  # noqa: ARG001
+    def update_color_picker(  # noqa: ARG001 # skipcq: PYL-W0613
+            attr: str, 
+            old: str, 
+            new: str) -> None:
         """Update the color picker when a new channel is selected."""
         if new:
             selected_color = color_source.data["colors"][new[0]]
@@ -262,7 +269,10 @@ def update_color_picker(attr: str, old: str, new: str) -> None:  # noqa: ARG001
         width=200,
     )
 
-    def enhance_cb(attr: str, old: str, new: str) -> None:  # noqa: ARG001 # skipcq: PYL-W0613
+    def enhance_cb(  # noqa: ARG001 # skipcq: PYL-W0613
+            attr: str, 
+            old: str, 
+            new: str) -> None:
         """Enhance slider callback."""
         UI["s"].put(
             f"http://{host2}:5000/tileserver/enhance",
@@ -929,14 +939,14 @@ def populate_slide_list(slide_folder: Path, search_txt: str | None = None) -> No
     UI["slide_select"].options = file_list
 
 
-def filter_input_cb(attr: str, old: str, new: str) -> None:  # noqa: ARG001
+def filter_input_cb(attr: str, old: str, new: str) -> None:  # noqa: ARG001 # skipcq: PYL-W0613
     """Change predicate to be used to filter annotations."""
     build_predicate()
     UI["vstate"].update_state = 1
     UI["vstate"].to_update.update(["overlay"])
 
 
-def cprop_input_cb(attr: str, old: str, new: list[str]) -> None:  # noqa: ARG001
+def cprop_input_cb(attr: str, old: str, new: list[str]) -> None:  # noqa: ARG001 # skipcq: PYL-W0613
     """Change property to color by."""
     if len(new) == 0:
         return