NameError: name 'logger' is not defined

[satoridev01]

Hi !

The following stacktrace was shown when running against the repo ludwig-ai/ludwig (but it was triggered by a GitHub GraphQL error, it may happen with other repositories as it cannot be reproduced with that one exactly)

This is the Traceback:

Traceback (most recent call last):
  File "/tmp/gh-workflow-auditor/main.py", line 60, in <module>
    main()
  File "/tmp/gh-workflow-auditor/main.py", line 58, in main
    action_auditor.action_audit()
  File "/tmp/gh-workflow-auditor/action_auditor.py", line 29, in action_audit
    self.check_usernames(usernames)
  File "/tmp/gh-workflow-auditor/action_auditor.py", line 22, in check_usernames
    renamed_or_not = self.gh.stale_checker(username=username)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/gh-workflow-auditor/github_wrapper.py", line 118, in stale_checker
    is_it_user = self.call_graphql(query=user_query)['data']['user']
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/gh-workflow-auditor/github_wrapper.py", line 49, in call_graphql
    logger.error(f"GitHub GraphQL Query failed: {message}")
    ^^^^^^
NameError: name 'logger' is not defined

I believe the error happens in https://github.com/TinderSec/gh-workflow-auditor/blob/main/github_wrapper.py#L49:

logger.error(f"GitHub GraphQL Query failed: {message}")

I believe that that line should be:

self.logger.error(f"GitHub GraphQL Query failed: {message}")

When the class is initialized the logger of the object is defined and referenced with self.logger, except only for that one. Referencing the self logger should do the trick to properly log the error.

[Xenorf]

Hello @satoridev01, I made a PR #19 that should fix this behavior. It was not yet accepted but you can take a look at it 😉

[satoridev01]

Agree, https://github.com/TinderSec/gh-workflow-auditor/pull/19/files#diff-8a846e356d747dd515192b9b46c5319123461f9ab81eb86953448b1b2bd85fabR79 covers that bug!