Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in toolchain definition is not detected? #101

Open
weedless opened this issue Jan 14, 2022 · 1 comment
Open

Change in toolchain definition is not detected? #101

weedless opened this issue Jan 14, 2022 · 1 comment

Comments

@weedless
Copy link

Hi!

I am working with a C++ project and wanted to apply bazel-diff there. When I do changes in a toolchain definition (e.g. in a typical cc_toolchain_config.bzl file) it seems not to be detected.

Bazel handles toolchain resolution implicit to the target definitions. Could it be that bazel-diff misses those dependencies when it runs a normal query? In our project we add toolchains using the command line parameter --extra_toolchains which is not supported when running a bazel query.

@tinder-maxwellelliott
Copy link
Collaborator

I think this capability could fix this? 3098e27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants