Merge pull request #103 from fahhem/patch-1

tinder-maxwellelliott · web-flow · commit d29699cee23e · 2022-03-21T10:21:34.000-07:00
Remove unnecessary copy of targetDigest
diff --git a/src/main/java/com/bazel_diff/TargetHashingClient.java b/src/main/java/com/bazel_diff/TargetHashingClient.java
@@ -189,9 +189,7 @@ private Map<String, String> hashAllTargets(byte[] seedHash, Map<String, BazelSou
                     seedHash
             );
             if (targetDigest != null) {
-                ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
-                outputStream.write(targetDigest);
-                targetHashes.put(targetName, convertByteArrayToString(outputStream.toByteArray()));
+                targetHashes.put(targetName, convertByteArrayToString(targetDigest));
             }
         }
         return targetHashes;

Original file line number	Diff line number	Diff line change
`@@ -189,9 +189,7 @@ private Map<String, String> hashAllTargets(byte[] seedHash, Map<String, BazelSou`
`189`	`189`	`seedHash`
`190`	`190`	`);`
`191`	`191`	`if (targetDigest != null) {`
`192`		`- ByteArrayOutputStream outputStream = new ByteArrayOutputStream();`
`193`		`- outputStream.write(targetDigest);`
`194`		`- targetHashes.put(targetName, convertByteArrayToString(outputStream.toByteArray()));`
	`192`	`+ targetHashes.put(targetName, convertByteArrayToString(targetDigest));`
`195`	`193`	`}`
`196`	`194`	`}`
`197`	`195`	`return targetHashes;`