Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping is not following the lifecycle #229

Open
yumiki opened this issue Sep 21, 2023 · 0 comments
Open

Ping is not following the lifecycle #229

yumiki opened this issue Sep 21, 2023 · 0 comments

Comments

@yumiki
Copy link

yumiki commented Sep 21, 2023

Hi,

There is an issue related to the usage of pingInterval in OkHttpClient. When the WebSocket is closed and this parameter is set, a new socket is promptly opened to perform the next ping. IMHO the ping mechanism should adhere to the lifecycle specified in the Scarlet builder.

To replicate this issue, you can refer to the code provided in the following link and add a lifecycle to the scarlet builder:
#70 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant