Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[message-adapter-moshi] Avoid 'kotlin-reflect' switching from 'moshi-kotlin' to 'moshi' #196

Open
xanscale opened this issue Nov 2, 2021 · 0 comments
Labels
enhancement New feature or request pr welcome Feel free to submit a PR

Comments

@xanscale
Copy link

xanscale commented Nov 2, 2021

moshi-kotlin transitively depends on the kotlin-reflect library which is a 2.5 MiB .jar file.

in that way you can use each codegen or reflection inside final app

also retrofit adapter use moshi instead of moshi-kotlin

it require to change just the dependency in gradle and not require code change at all

@xanscale xanscale changed the title inside message-adapter-moshi switch from moshi-kotlin to moshi to avoid kotlin-reflect [message-adapter-moshi] switch from moshi-kotlin to moshi to avoid kotlin-reflect Nov 2, 2021
@xanscale xanscale changed the title [message-adapter-moshi] switch from moshi-kotlin to moshi to avoid kotlin-reflect [message-adapter-moshi] avoid 'kotlin-reflect' switching from 'moshi-kotlin' to 'moshi' Nov 2, 2021
@xanscale xanscale changed the title [message-adapter-moshi] avoid 'kotlin-reflect' switching from 'moshi-kotlin' to 'moshi' [message-adapter-moshi] Avoid 'kotlin-reflect' switching from 'moshi-kotlin' to 'moshi' Nov 2, 2021
@tinder-ahe tinder-ahe added enhancement New feature or request pr welcome Feel free to submit a PR labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome Feel free to submit a PR
Projects
None yet
Development

No branches or pull requests

2 participants