Apply standard Swift package configuration (#7)

* Apply standard Swift package configuration

* Fix Xcode version

Author: tinder-cfuller

.github/workflows/artifactory.yml

@@ -5,7 +5,7 @@ on:
     tags: ['[0-9]+.[0-9]+.[0-9]+']
 
 env:
-  DEVELOPER_DIR: /Applications/Xcode_14.3.app/Contents/Developer
+  DEVELOPER_DIR: /Applications/Xcode_15.0.app/Contents/Developer
 
 jobs:
   artifactory:

.github/workflows/bazel.yml

@@ -7,7 +7,7 @@ on:
     branches: [ main ]
 
 env:
-  DEVELOPER_DIR: /Applications/Xcode_14.3.app/Contents/Developer
+  DEVELOPER_DIR: /Applications/Xcode_15.0.app/Contents/Developer
 
 jobs:
   bazel:

.github/workflows/swift.yml

@@ -7,7 +7,7 @@ on:
     branches: [ main ]
 
 env:
-  DEVELOPER_DIR: /Applications/Xcode_14.3.app/Contents/Developer
+  DEVELOPER_DIR: /Applications/Xcode_15.0.app/Contents/Developer
 
 jobs:
   swift:
@@ -29,5 +29,5 @@ jobs:
       run: xcodebuild -resolvePackageDependencies
     - name: Build
       run: xcodebuild build-for-testing -scheme "CollectionBuilders" -destination "name=$SIMULATOR,OS=latest"
-    - name: Run tests
+    - name: Test
       run: xcodebuild test-without-building -scheme "CollectionBuilders" -destination "name=$SIMULATOR,OS=latest"

.swiftlint-rules.yml

@@ -11,7 +11,7 @@ only_rules:
 - anonymous_argument_in_multiline_closure
 - anyobject_protocol
 - array_init
-- attributes
+# - attributes
 - balanced_xctest_lifecycle
 - blanket_disable_command
 - block_based_kvo
@@ -129,6 +129,7 @@ only_rules:
 - no_grouping_extension
 # - no_magic_numbers
 - no_space_in_method_call
+- non_overridable_class_declaration
 - notification_center_detachment
 - ns_number_init_as_function_reference
 - nslocalizedstring_key
@@ -154,6 +155,7 @@ only_rules:
 - private_outlet
 - private_over_fileprivate
 - private_subject
+- private_swiftui_state
 - private_unit_test
 - prohibited_interface_builder
 - prohibited_super_call
@@ -209,6 +211,7 @@ only_rules:
 - unavailable_function
 - unhandled_throwing_task
 - unneeded_break_in_switch
+# - unneeded_override
 - unneeded_parentheses_in_closure_argument
 - unneeded_synthesized_initializer
 - unowned_variable_capture

Package.resolved

@@ -14,17 +14,17 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/mattgallagher/CwlPreconditionTesting.git",
       "state" : {
-        "revision" : "a23ded2c91df9156628a6996ab4f347526f17b6b",
-        "version" : "2.1.2"
+        "revision" : "dc9af4781f2afdd1e68e90f80b8603be73ea7abc",
+        "version" : "2.2.0"
       }
     },
     {
       "identity" : "nimble",
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/Quick/Nimble.git",
       "state" : {
-        "revision" : "f552a16f434eef1f18b62985172489f41d37a18e",
-        "version" : "12.2.0"
+        "revision" : "d616f15123bfb36db1b1075153f73cf40605b39d",
+        "version" : "13.0.0"
       }
     }
   ],

Package.swift

@@ -1,4 +1,4 @@
-// swift-tools-version:5.8
+// swift-tools-version:5.9
 
 import PackageDescription
 
@@ -22,7 +22,7 @@ let package = Package(
     dependencies: [
         .package(
             url: "https://github.com/Quick/Nimble.git",
-            from: "12.0.0"),
+            from: "13.0.0"),
     ],
     targets: [
         .target(
@@ -48,7 +48,7 @@ let package = Package(
             path: "Plugins/SwiftLintPlugin"),
         .binaryTarget(
             name: SwiftLint.binary,
-            url: "https://github.com/realm/SwiftLint/releases/download/0.52.4/SwiftLintBinary-macos.artifactbundle.zip",
-            checksum: "8a8095e6235a07d00f34a9e500e7568b359f6f66a249f36d12cd846017a8c6f5"),
+            url: "https://github.com/realm/SwiftLint/releases/download/0.54.0/SwiftLintBinary-macos.artifactbundle.zip",
+            checksum: "963121d6babf2bf5fd66a21ac9297e86d855cbc9d28322790646b88dceca00f1"),
     ]
 )

Plugins/SwiftLintPlugin/SwiftLintPlugin.swift

@@ -62,7 +62,9 @@ internal struct SwiftLintPlugin: BuildToolPlugin {
         target: Target
     ) throws -> [String: String] {
 
-        let workingDirectory: Path = try target.directory.resolveWorkingDirectory(in: context.package.directory)
+        let workingDirectory: Path = try target
+            .directory
+            .resolveWorkingDirectory(in: context.package.directory)
 
         return ["BUILD_WORKSPACE_DIRECTORY": "\(workingDirectory)"]
     }
@@ -76,9 +78,12 @@ internal struct SwiftLintPlugin: BuildToolPlugin {
 
         print("Environment:", environment)
 
+        guard !swiftFiles.isEmpty
+        else { return [] }
+
         let arguments: [String] = ["lint", "--quiet", "--force-exclude", "--cache-path", "\(path)"]
 
-        return swiftFiles.isEmpty ? [] : [
+        return [
             .prebuildCommand(
                 displayName: "SwiftLint",
                 executable: executable.path,