Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support onSendProgress for all request body types #13

Open
Tienisto opened this issue Aug 23, 2024 · 0 comments
Open

Support onSendProgress for all request body types #13

Tienisto opened this issue Aug 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Tienisto
Copy link
Owner

Tienisto commented Aug 23, 2024

Currently, the body type must be either HttpBody.bytes or HttpBody.stream (internally, HttpBody.bytes is converted to HttpBody.stream).

HttpBody.text and HttpBody.form might be convertable to HttpBody.stream too but then we introduce logic in Dart that might be inconsistent with reqwest.

HttpBody.multipart is an even bigger problem.

The best case would be if reqwest exposes an API for us: seanmonstar/reqwest#262

Edit: It seems that another library doesn't implement multipart either: algesten/ureq#698
So maybe we just ditch the "multipart" feature of reqwest, and build the byte stream ourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant