Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Confusing Empty Message on Tag Picker DropDown #8593

Closed
kookma opened this issue Sep 12, 2024 · 1 comment · Fixed by #8649
Closed

[BUG] Confusing Empty Message on Tag Picker DropDown #8593

kookma opened this issue Sep 12, 2024 · 1 comment · Fixed by #8649

Comments

@kookma
Copy link
Contributor

kookma commented Sep 12, 2024

Describe the bug

I think this is related to (by @Leilei332)
7cb678c

Look at the below screenshot. Two redundant messages. This is confusing.

msedge_img_289_20240912

Expected behavior

I think the second message is related to system tags (or tags started with $:/), so for readability I propose to use

(no search results in system tags) or something clearer!

TiddlyWiki Configuration

-TW 5.3.6pre
-Edge 128
-Windows 11

@Jermolene
Copy link
Member

Hi @kookma @Leilei332 that is a good point.

The preferred solution would be to detect the situation where both lists are empty, and display a single message, but I fear there might be a performance impact.

Alternatively, instead of a textual empty message we could perhaps use an icon of a search magnifier with an "X" in the middle, like this one, but rendered in a muted colour:

image

The existing text would be the aria label/tooltip for the icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants