Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikitext transclusions don't produce "start / stop" info in parse-tree #7259

Closed
pmario opened this issue Feb 10, 2023 · 3 comments
Closed

wikitext transclusions don't produce "start / stop" info in parse-tree #7259

pmario opened this issue Feb 10, 2023 · 3 comments

Comments

@pmario
Copy link
Member

pmario commented Feb 10, 2023

The following code should produce start / stop info .. At least the info that is available with the regexp matches.


{{test}}

{{{[tag[HelloThere]]|tooltip}}}.xx.yyy

image


attribute start stop as with eg: list-widget is not possible atm without much more code in the parser. More code will be bad for the parse-speed.

image

this issue is related to: pragmas don't produce "start / end" markers in the parse-tree #6822

We should check all the wikitext parsers.

@pmario
Copy link
Member Author

pmario commented Feb 10, 2023

I did a bit of debugging.

  • this.match.index contains the start of the whole string ... This info may be usable. a bit more testing needed.
  • this.matchRegExp.lastIndex; contains the last char.

@pmario
Copy link
Member Author

pmario commented Dec 10, 2023

Should be fixed with PR: Add start and end properties to WikiText AST nodes for all elements. #7866

@pmario
Copy link
Member Author

pmario commented Jan 1, 2025

close -- this one has been fixed since then

@pmario pmario closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant