Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document mistake on default hash algorithm of TOTP #7

Open
50Death opened this issue May 6, 2023 · 0 comments
Open

Document mistake on default hash algorithm of TOTP #7

50Death opened this issue May 6, 2023 · 0 comments

Comments

@50Death
Copy link

50Death commented May 6, 2023

All the document says the default hash algorithm of TOTP is SHA1, but apparently the code says it is SHA256.

Screenshot of the document
image
image

Screenshot of the code
image

Althrough sha256 may be more secured than sha1. Still most authenticator apps(Microsoft or Google) do not support it. I guess it's more suitable to set the default SHA1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant