From ab7784cffdf3fddf506b4dce9a4d2ba8d4fe87e7 Mon Sep 17 00:00:00 2001
From: ThibaultBee <37510686+ThibaultBee@users.noreply.github.com>
Date: Thu, 8 Aug 2024 15:38:48 +0200
Subject: [PATCH] fix(core): do not throw when an exception `lifecycleScope` is
 null

---
 .../io/github/thibaultbee/streampack/views/PreviewView.kt  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/core/src/main/java/io/github/thibaultbee/streampack/views/PreviewView.kt b/core/src/main/java/io/github/thibaultbee/streampack/views/PreviewView.kt
index 9f9a7114c..1d425b996 100644
--- a/core/src/main/java/io/github/thibaultbee/streampack/views/PreviewView.kt
+++ b/core/src/main/java/io/github/thibaultbee/streampack/views/PreviewView.kt
@@ -92,12 +92,10 @@ class PreviewView @JvmOverloads constructor(
          */
         set(value) {
             stopPreviewInternal()
+            field = value
             value?.let {
-                lifecycleScope?.launch {
-                    startPreviewInternal(it, it.camera, size)
-                }
+                startPreviewIfReady(it, size, false)
             }
-            field = value
         }
 
     /**
@@ -311,6 +309,7 @@ class PreviewView @JvmOverloads constructor(
                     listener?.onPreviewStarted()
                 } else {
                     Logger.w(TAG, "Invalid surface")
+                    listener?.onPreviewFailed(IllegalStateException("Invalid surface"))
                 }
             }
         } catch (e: CancellationException) {