Skip to content

Commit c517564

Browse files
authored
Merge pull request #41 from TheRealDjmr/unlimitedpassives
Unlimitedpassives
2 parents dff8c66 + e4573e4 commit c517564

File tree

5 files changed

+570
-28
lines changed

5 files changed

+570
-28
lines changed

ImprovedUI/Public/Game/GUI/Library/CCLib_k.xaml

+20-17
Original file line numberDiff line numberDiff line change
@@ -708,14 +708,14 @@
708708
<ContentControl DockPanel.Dock="Top" ContentTemplate="{DynamicResource PassiveSelectorItemTemplate}" Content="{Binding .}"/>
709709
</StackPanel>
710710

711-
<ls:LSScrollViewer Style="{StaticResource gameplayPanelScrollViewerStyle}" Height="Auto" VerticalScrollBarVisibility="Auto">
711+
<ls:LSScrollViewer Style="{StaticResource gameplayPanelScrollViewerStyle}" Height="Auto" VerticalScrollBarVisibility="Auto">
712712
<StackPanel Style="{StaticResource gameplayScrolledStackPanelStyle}">
713713

714714
<!-- Features that may depend on passive selection above -->
715715
<!-- ToDo: only show things that actually depend, also separate class/subclass -->
716716
<ItemsControl ItemsSource="{Binding FilteredItems, ElementName=ClassPassiveFeatures}" ItemTemplate="{StaticResource ProgressionSpellsTemplate}" Visibility="{Binding FilteredItems.Count, ElementName=ClassPassiveFeatures, Converter={StaticResource CountToVisibilityConverter}}" Margin="0,20,0,0"/>
717717

718-
<ItemsControl ItemsSource="{Binding FilteredItems, ElementName=SubClassPassiveFeatures}" ItemTemplate="{StaticResource ProgressionSpellsTemplate}" Visibility="{Binding FilteredItems.Count, ElementName=SubClassPassiveFeatures, Converter={StaticResource CountToVisibilityConverter}}" Margin="0,20,0,0"/>
718+
<ItemsControl ItemsSource="{Binding FilteredItems, ElementName=SubClassPassiveFeatures}" ItemTemplate="{StaticResource ProgressionSpellsTemplate}" Visibility="{Binding FilteredItems.Count, ElementName=SubClassPassiveFeatures, Converter={StaticResource CountToVisibilityConverter}}" Margin="0,20,0,0" />
719719

720720
<StackPanel x:Name="PiercingSelector" Visibility="Collapsed" Margin="0,50,0,0">
721721
<TextBlock Text="{Binding Source='h261cce55g1d1eg4c09g9675ge5c1be13e820', Converter={StaticResource TranslatedStringConverter}}" Style="{StaticResource PanelSubHeaderText}"/>
@@ -2318,20 +2318,23 @@
23182318
</TextBlock>
23192319
<TextBlock x:Name="description" ls:TextBlockFormatter.SourceText="{Binding Description.Text}" Style="{StaticResource PanelDescriptionText}" Margin="0,50,0,0"/>
23202320

2321-
<ItemsControl ItemsSource="{Binding Passives}" HorizontalAlignment="Center" Margin="-32,32,0,0">
2322-
<ItemsControl.ItemTemplate>
2323-
<DataTemplate DataType="{x:Type ls:VMCharacterCreationPassive}">
2324-
<ContentControl Template="{StaticResource SelectableEnhancement}">
2325-
<b:Interaction.Triggers>
2326-
<b:EventTrigger EventName="MouseLeftButtonUp">
2327-
<b:InvokeCommandAction Command="{Binding DataContext.TogglePassive,RelativeSource={RelativeSource AncestorType={x:Type ls:UIWidget}}}" CommandParameter="{Binding}" />
2328-
<ls:LSPlaySound Sound="UI_HUD_CC_ClassSubOption"/>
2329-
</b:EventTrigger>
2330-
</b:Interaction.Triggers>
2331-
</ContentControl>
2332-
</DataTemplate>
2333-
</ItemsControl.ItemTemplate>
2334-
</ItemsControl>
2321+
<!-- MOD START - Restrict passive list max height -->
2322+
<ls:LSScrollViewer Style="{StaticResource gameplayPanelScrollViewerStyle}" Height="1000" VerticalScrollBarVisibility="Auto">
2323+
<ItemsControl ItemsSource="{Binding Passives}" HorizontalAlignment="Center" Margin="-32,32,0,0">
2324+
<ItemsControl.ItemTemplate>
2325+
<DataTemplate DataType="{x:Type ls:VMCharacterCreationPassive}">
2326+
<ContentControl Template="{StaticResource SelectableEnhancement}">
2327+
<b:Interaction.Triggers>
2328+
<b:EventTrigger EventName="MouseLeftButtonUp">
2329+
<b:InvokeCommandAction Command="{Binding DataContext.TogglePassive,RelativeSource={RelativeSource AncestorType={x:Type ls:UIWidget}}}" CommandParameter="{Binding}" />
2330+
<ls:LSPlaySound Sound="UI_HUD_CC_ClassSubOption"/>
2331+
</b:EventTrigger>
2332+
</b:Interaction.Triggers>
2333+
</ContentControl>
2334+
</DataTemplate>
2335+
</ItemsControl.ItemTemplate>
2336+
</ItemsControl>
2337+
</ls:LSScrollViewer>
23352338

23362339
</StackPanel>
23372340
<DataTemplate.Triggers>
@@ -3639,7 +3642,7 @@
36393642

36403643
</StackPanel>
36413644

3642-
<ls:LSScrollViewer Style="{StaticResource gameplayPanelScrollViewerStyle}" VerticalScrollBarVisibility="Auto" Height="Auto" Margin="100,0,88,52">
3645+
<ls:LSScrollViewer Style="{StaticResource gameplayPanelScrollViewerStyle}" VerticalScrollBarVisibility="Auto" Height="Auto" Margin="100,0,88,52">
36433646
<StackPanel Style="{StaticResource gameplayScrolledStackPanelStyle}">
36443647

36453648
<!-- Name and description -->

ImprovedUI/Public/Game/GUI/StateMachine.xaml

+1-3
Original file line numberDiff line numberDiff line change
@@ -721,9 +721,7 @@
721721
<ls:StateWidget Filename="Overlay.xaml" Layer="Notifications"/>
722722
<ls:StateWidget Filename="WorldContextMenu.xaml" Layer="Notifications"/>
723723
<ls:StateWidget Filename="OverheadInfo.xaml" Layer="HUD" IgnoreHitTest="True"/>
724-
<!-- MOD START - Keyboard only tooltip toggle -->
725-
<ls:StateWidget Filename="WorldTooltips_k.xaml" Layer="HUD"/>
726-
<!-- MOD END -->
724+
<ls:StateWidget Filename="WorldTooltips.xaml" Layer="HUD"/>
727725
<ls:StateWidget Filename="HotBar.xaml" Layer="HUDTop"/>
728726
<ls:StateWidget Filename="ReactionDecisionPopup.xaml" Layer="Notifications"/>
729727
<ls:StateWidget Filename="Minimap.xaml" Layer="HUD"/>

0 commit comments

Comments
 (0)