Skip to content

Commit 1e29378

Browse files
ACTUALLY fix passive selectors on controller, for real this time (#329)
1 parent cde0240 commit 1e29378

File tree

2 files changed

+38
-1
lines changed

2 files changed

+38
-1
lines changed

ImprovedUI/Public/Game/GUI/Library/CCLib_c.xaml

+34-1
Original file line numberDiff line numberDiff line change
@@ -1520,7 +1520,7 @@
15201520
</MultiDataTrigger>
15211521

15221522
<!-- Passive subtabs -->
1523-
<!-- MOD START - Racial passive selection -->
1523+
<!-- MOD START - Racial passive selection (CC) -->
15241524
<MultiDataTrigger>
15251525
<MultiDataTrigger.Conditions>
15261526
<Condition Binding="{Binding Path=Tag, RelativeSource={RelativeSource Mode=Self}}" Value="race"/>
@@ -1575,6 +1575,26 @@
15751575
<Setter TargetName="subTabs" Property="Visibility" Value="Visible"/>
15761576
<Setter TargetName="subTabsPassivesList" Property="ItemsSource" Value="{Binding ClassProgressionDetails.NotSubPassiveSelectors}"/>
15771577
</MultiDataTrigger>
1578+
<!-- MOD START - Racial passive selection (LevelUp) -->
1579+
<MultiDataTrigger>
1580+
<MultiDataTrigger.Conditions>
1581+
<Condition Binding="{Binding DataContext.IsLevelUp, RelativeSource={RelativeSource AncestorType={x:Type ls:UIWidget}}, FallbackValue=False}" Value="True"/>
1582+
<Condition Binding="{Binding Path=Tag, RelativeSource={RelativeSource Mode=Self}}" Value="race"/>
1583+
<Condition Binding="{Binding Path=RaceProgressionDetails.NotSubPassiveSelectors.Count, Converter={StaticResource GreaterThanConverter}, ConverterParameter=0}" Value="True"/>
1584+
</MultiDataTrigger.Conditions>
1585+
<Setter TargetName="subTabs" Property="Visibility" Value="Visible"/>
1586+
<Setter TargetName="subTabsPassivesList" Property="ItemsSource" Value="{Binding RaceProgressionDetails.NotSubPassiveSelectors}"/>
1587+
</MultiDataTrigger>
1588+
<MultiDataTrigger>
1589+
<MultiDataTrigger.Conditions>
1590+
<Condition Binding="{Binding DataContext.IsLevelUp, RelativeSource={RelativeSource AncestorType={x:Type ls:UIWidget}}, FallbackValue=False}" Value="True"/>
1591+
<Condition Binding="{Binding Path=Tag, RelativeSource={RelativeSource Mode=Self}}" Value="race"/>
1592+
<Condition Binding="{Binding Path=RaceProgressionDetails.SubPassiveSelectors.Count, Converter={StaticResource GreaterThanConverter}, ConverterParameter=0}" Value="True"/>
1593+
</MultiDataTrigger.Conditions>
1594+
<Setter TargetName="subTabs" Property="Visibility" Value="Visible"/>
1595+
<Setter TargetName="subTabsPassivesList" Property="ItemsSource" Value="{Binding RaceProgressionDetails.SubPassiveSelectors}"/>
1596+
</MultiDataTrigger>
1597+
<!-- MOD END -->
15781598

15791599
<!-- Equipment subtabs -->
15801600
<MultiDataTrigger>
@@ -1884,6 +1904,19 @@
18841904
<Setter TargetName="subTabsSpellsList" Property="ItemsSource" Value="{Binding RaceProgressionDetails.SubSpellSelectors}"/>
18851905
</DataTrigger>
18861906

1907+
<!-- MOD START - Racial passive selection -->
1908+
1909+
<DataTrigger Binding="{Binding Path=Tag, RelativeSource={RelativeSource Mode=Self}}" Value="race">
1910+
<Setter TargetName="subTabs" Property="Visibility" Value="Visible"/>
1911+
<Setter TargetName="subTabsPassivesList" Property="ItemsSource" Value="{Binding RaceProgressionDetails.NotSubPassiveSelectors}"/>
1912+
</DataTrigger>
1913+
<DataTrigger Binding="{Binding Path=Tag, RelativeSource={RelativeSource Mode=Self}}" Value="subrace">
1914+
<Setter TargetName="subTabs" Property="Visibility" Value="Visible"/>
1915+
<Setter TargetName="subTabsPassivesList" Property="ItemsSource" Value="{Binding RaceProgressionDetails.SubPassiveSelectors}"/>
1916+
</DataTrigger>
1917+
1918+
<!-- MOD END -->
1919+
18871920
<DataTrigger Binding="{Binding Path=Tag, RelativeSource={RelativeSource Mode=Self}}" Value="class">
18881921
<Setter TargetName="subTabs" Property="Visibility" Value="Visible"/>
18891922
<Setter TargetName="subTabsSpellsList" Property="ItemsSource" Value="{Binding ClassProgressionDetails.NotSubSpellSelectors}"/>

ImprovedUI/Public/Game/GUI/Widgets/CharacterCreation_c.xaml

+4
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,8 @@
240240
<!-- MOD START - Racial passive selection -->
241241
<ls:CollectionFilterBehavior x:Name="RacePassiveFeatures" ItemsSource="{Binding RacePassiveFeatures}" Predicate="{Binding IsNotSubProgressionPredicate}"/>
242242
<ls:CollectionFilterBehavior x:Name="SubRacePassiveFeatures" ItemsSource="{Binding RacePassiveFeatures}" Predicate="{Binding IsSubProgressionPredicate}"/>
243+
<ls:CollectionFilterBehavior x:Name="RacePassiveSelectors" ItemsSource="{Binding RaceProgressionDetails.NotSubPassiveSelectors}"/>
244+
<ls:CollectionFilterBehavior x:Name="SubRacePassiveSelectors" ItemsSource="{Binding RaceProgressionDetails.SubPassiveSelectors}"/>
243245
<!-- MOD END -->
244246
<ls:CollectionFilterBehavior x:Name="ClassPassiveFeatures" ItemsSource="{Binding PassiveFeatures}" Predicate="{Binding IsNotSubProgressionPredicate}"/>
245247
<ls:CollectionFilterBehavior x:Name="SubClassPassiveFeatures" ItemsSource="{Binding PassiveFeatures}" Predicate="{Binding IsSubProgressionPredicate}"/>
@@ -1046,6 +1048,7 @@
10461048

10471049
<!-- MOD START - Racial passive selection -->
10481050
<ItemsControl ItemsSource="{Binding FilteredItems, ElementName=RacePassiveFeatures}" ItemTemplate="{StaticResource progressionSpellsTemplate}" Visibility="{Binding FilteredItems.Count, ElementName=RacePassiveFeatures, Converter={StaticResource CountToVisibilityConverter}}"/>
1051+
<ItemsControl ItemsSource="{Binding FilteredItems, ElementName=RacePassiveSelectors}" ItemTemplate="{StaticResource progressionSpellsTemplate}" Visibility="{Binding FilteredItems.Count, ElementName=RacePassiveSelectors, Converter={StaticResource CountToVisibilityConverter}}"/>
10491052
<!-- MOD END -->
10501053

10511054
<Control Template="{StaticResource progressionFeaturesList}" DataContext="{Binding ProgressionData.RaceProgression}" HorizontalAlignment="Center"/>
@@ -1108,6 +1111,7 @@
11081111

11091112
<!-- MOD START - Racial passive selection -->
11101113
<ItemsControl ItemsSource="{Binding FilteredItems, ElementName=SubRacePassiveFeatures}" ItemTemplate="{StaticResource progressionSpellsTemplate}" Visibility="{Binding FilteredItems.Count, ElementName=RacePassiveFeatures, Converter={StaticResource CountToVisibilityConverter}}"/>
1114+
<ItemsControl ItemsSource="{Binding FilteredItems, ElementName=SubRacePassiveSelectors}" ItemTemplate="{StaticResource progressionSpellsTemplate}" Visibility="{Binding FilteredItems.Count, ElementName=SubRacePassiveSelectors, Converter={StaticResource CountToVisibilityConverter}}"/>
11111115
<!-- MOD END -->
11121116

11131117
<Control Template="{StaticResource progressionFeaturesList}" DataContext="{Binding ProgressionData.SubRaceProgression}" HorizontalAlignment="Center"/>

0 commit comments

Comments
 (0)