Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When two windows are open, only the current is highlighted and, I don't think, this is mentioend once. #126

Open
Nilabb opened this issue Jul 4, 2024 · 0 comments

Comments

@Nilabb
Copy link

Nilabb commented Jul 4, 2024

Sorry if this is a silly issue but I can see how new users of neovim, (I know firsthand), would get confused about this.

In the ColorMyPencils function the highlight group set is the normal group, which doesn't include non-current windows. To include non-current windows, vim.api.nvim_set_hl(0, "NormalNC", {bg = none}) should also be set. The video makes it seem like the current colors.lua file re-colours all windows, but it doesn't. This stumped me, for a long time, and potentially other users so I thought it should be mentioned somewhere in this repo, in the comments of the 0 to lsp video, or in the description.

I'm not gonna tell ThePrimeagen how he should set his dotfiles, but I think he should have made it clear for people whose first neovim experience was that video the highlight group only includes the current window, instead of calling the normal highlight group "the thing this is just vim".

For people who combat this with "READ THE FUCKING MANUAL", I think you're partially right. This was a good learning experience for me and taught me about navigating documentation within vim and neovim. But, it also took me a long time scrubbing through my config looking for an error which could've been avoided, and I hope this issue can help other people like me who didn't know a thing about lua, or much about neovim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant