You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry if this is a silly issue but I can see how new users of neovim, (I know firsthand), would get confused about this.
In the ColorMyPencils function the highlight group set is the normal group, which doesn't include non-current windows. To include non-current windows, vim.api.nvim_set_hl(0, "NormalNC", {bg = none}) should also be set. The video makes it seem like the current colors.lua file re-colours all windows, but it doesn't. This stumped me, for a long time, and potentially other users so I thought it should be mentioned somewhere in this repo, in the comments of the 0 to lsp video, or in the description.
I'm not gonna tell ThePrimeagen how he should set his dotfiles, but I think he should have made it clear for people whose first neovim experience was that video the highlight group only includes the current window, instead of calling the normal highlight group "the thing this is just vim".
For people who combat this with "READ THE FUCKING MANUAL", I think you're partially right. This was a good learning experience for me and taught me about navigating documentation within vim and neovim. But, it also took me a long time scrubbing through my config looking for an error which could've been avoided, and I hope this issue can help other people like me who didn't know a thing about lua, or much about neovim.
The text was updated successfully, but these errors were encountered:
Sorry if this is a silly issue but I can see how new users of neovim, (I know firsthand), would get confused about this.
In the ColorMyPencils function the highlight group set is the normal group, which doesn't include non-current windows. To include non-current windows,
vim.api.nvim_set_hl(0, "NormalNC", {bg = none})
should also be set. The video makes it seem like the currentcolors.lua
file re-colours all windows, but it doesn't. This stumped me, for a long time, and potentially other users so I thought it should be mentioned somewhere in this repo, in the comments of the 0 to lsp video, or in the description.I'm not gonna tell ThePrimeagen how he should set his dotfiles, but I think he should have made it clear for people whose first neovim experience was that video the highlight group only includes the current window, instead of calling the normal highlight group "the thing this is just vim".
For people who combat this with "READ THE FUCKING MANUAL", I think you're partially right. This was a good learning experience for me and taught me about navigating documentation within vim and neovim. But, it also took me a long time scrubbing through my config looking for an error which could've been avoided, and I hope this issue can help other people like me who didn't know a thing about lua, or much about neovim.
The text was updated successfully, but these errors were encountered: