Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Rename project submissions has_live_preview to previewable #4003

Closed
KevinMulhern opened this issue Jul 20, 2023 · 2 comments · Fixed by #4039
Closed

Chore: Rename project submissions has_live_preview to previewable #4003

KevinMulhern opened this issue Jul 20, 2023 · 2 comments · Fixed by #4039
Assignees
@ZachBaird
Labels
Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.

Comments

@KevinMulhern
Copy link
Member

Because:

2. Acceptance Criteria:

  • The has_live_preview column name is renamed to previewable on the project submissions table
  • All occurrences of has_live_preview throughout the codebase have been switched to previewable

3. Additional Information:
@KevinMulhern KevinMulhern added Status: Needs Review This issue/PR needs an initial or additional review Status: On Hold There is a temporary hold on any continued work or review and removed Status: Needs Review This issue/PR needs an initial or additional review labels Jul 20, 2023
@KevinMulhern
Copy link
Member Author

Blocked until we move fully to the new Hotwire version of submissions.

@KevinMulhern KevinMulhern mentioned this issue Jul 20, 2023
Merged
@KevinMulhern KevinMulhern added Status: Help Wanted This issue can be assigned to other contributors and removed Status: On Hold There is a temporary hold on any continued work or review labels Jul 27, 2023
@ZachBaird
Copy link
Contributor

I can take this @KevinMulhern

@ManonLef ManonLef added Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. and removed Status: Help Wanted This issue can be assigned to other contributors labels Jul 28, 2023
@ZachBaird ZachBaird mentioned this issue Jul 28, 2023
Merged
7 tasks
KevinMulhern pushed a commit that referenced this issue Jul 29, 2023
@ZachBaird
Chore: Renames has_live_preview column to previewable. (#4039)
6fd725d 
## Because
The new column name is Railsyer.


## This PR
- Adds a migration to rename lesson.has_live_preview to
lesson.previewable
- Changes all instances of has_live_preview to be previewable in the
codebase.


## Issue
Closes #4003 

## Additional Information
As a matter of clarification, the task assumed the has_live_preview
column was in the project_submissions table. It was actually on the
lessons table.


## Pull Request Requirements
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
  - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
  - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [x] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [x] If applicable, this PR includes new or updated automated tests
Mclilzee pushed a commit to Mclilzee/theodinproject that referenced this issue Aug 2, 2023
@ZachBaird @Mclilzee
Chore: Renames has_live_preview column to previewable. (TheOdinProjec…
1b09a71 
…t#4039)

## Because
The new column name is Railsyer.


## This PR
- Adds a migration to rename lesson.has_live_preview to
lesson.previewable
- Changes all instances of has_live_preview to be previewable in the
codebase.


## Issue
Closes TheOdinProject#4003 

## Additional Information
As a matter of clarification, the task assumed the has_live_preview
column was in the project_submissions table. It was actually on the
lessons table.


## Pull Request Requirements
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
  - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
  - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [x] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [x] If applicable, this PR includes new or updated automated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZachBaird ZachBaird

Labels
Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: Renames has_live_preview column to previewable. ZachBaird/theodinproject
3 participants
@KevinMulhern @ZachBaird @ManonLef