-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS: HashMap exercise needs explicit suggestion to use 16 buckets at start #29162
Comments
Seems like a good idea to me, thanks! |
@Alfa06N if you leave a comment here I'll assign you since I see you already have a PR related to this issue. So that you know for the future though we prefer people not put up PRs for existing issues until they are assigned to them. |
Thank you for letting me know! I appreciate the clarification and will make sure to wait for assignment in the future before submitting a PR. Please feel free to assign this issue to me now since I have already submitted the related PR. |
@wise-king-sullyman Hello! I'd like this issue to be assigned to me and my PR to be helpful. |
This is one of my first PRs, should I do anything else before my PR is accepted? Should I change something about it? |
This issue is stale because it has had no activity for the last 30 days. |
Checks
Describe your suggestion
The HashMap exercise does not explicitly state that the initial buckets used should be 16 but the test setup uses 12 pieces of data which happens to be exactly .75 x 16. In order to reconcile the test steps with the earlier instructions, the earlier instructions need to explicitly state "The initial value for capacity should be 16." it can state that right after this part:
Once we have explicit directions to create an initial set of 16 buckets, the test instructions make sense (while as they stand now, they really really don't. For eg. If I had picked a capacity size of 19, then 12 pieces of data would definitely not have allowed me to reach a .75 load level)
thanks for your attention to the matter.
Path
Node / JS
Lesson Url
https://www.theodinproject.com/lessons/javascript-hashmap
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered: