post_file_annotation can now create orphaned FileAnnotations
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickmartins
added a commit
that referenced
this pull request
Jan 23, 2024
* Automated updating coverage badge * bump to 5.13.1, fix for SSL (#76) * Automated updating coverage badge * `put_description` implemented (#78) * docstring and function signature * function is there and on init - on to tests * tests passing * flake8 pass * updated upload to test pypi to use python 3.8 * adds `get_comment_annotation_ids`, `get_comment_annotation`, `post_comment_annotation` (#79) * added `get_comment_ids` * added `get_comment` * added `post_comment_annotation` * added `test_get_comment_annotation_and_ids` * added `test_post_get_comment_annotation`, all passing * Automated updating coverage badge * fixed typo that set fill color instead of stroke color when stroke not specified (#82) * Automated updating coverage badge * Doi and numpy (#85) * added publication badge * fixed badge * future-proofing against numpy 2.0.0 * added CITATION.cff * Automated updating coverage badge * fixing leftover datasets when `post_dataset` fails to link it to a project (#87) * deleting created dataset if it cannot be linked to project * removed naked except and bad type tests * flake8 * removing print * Automated updating coverage badge * updating omero-py version (#91) * Automated updating coverage badge * changed list of points to be space-separated (#93) * changed list of points to be space-separated * fixing EOL issue * Automated updating coverage badge * `post_file_annotation` can now create orphaned `FileAnnotation`s (#92) * updating omero-py version * post_file_annotation can do orphans * Automated updating coverage badge * updated omero-py version (#94) * updated omero-py version * fix typo in docstring because why not * using glencoe's zeroc-ice * it's installing too fast (!!!) now * Automated updating coverage badge * updated docs --------- Co-authored-by: Erick Ratamero <[email protected]> Co-authored-by: Kiya Govek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
post_file_annotationcan only create aFileAnnotationattached to an existing object. This update allows for orphanedFileAnnotations too - important to create e.g. Figures.Note; THIS CHANGES THE FUNCTION SIGNATURE. A few arguments are now optional, and need to come after positional arguments.
Checklist
Docstrings updated, new unit tests added, flake8 passing.
For reviewers
later.
__init__.py.