Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Data Chunk (0x2020) #5

Open
TheCyberRonin opened this issue May 30, 2020 · 6 comments
Open

User Data Chunk (0x2020) #5

TheCyberRonin opened this issue May 30, 2020 · 6 comments
Assignees
@TheCyberRonin
Labels
enhancement New feature or request

Comments

@TheCyberRonin
Copy link
Owner

No description provided.

@TheCyberRonin TheCyberRonin added Parser enhancement New feature or request and removed Parser labels May 30, 2020
@jemc
Copy link
Contributor

jemc commented Aug 15, 2022 •
edited
Loading

I have working code for this feature too.

Do you want me to attach it to the same PR #11 or wait until that one is merged and do a separate PR?

@TheCyberRonin
Copy link
Owner Author

Wait until the other is merged. I'll do the testing this evening!

@TheCyberRonin TheCyberRonin self-assigned this Dec 4, 2022
@zastrowm
Copy link

Is this feature still planned?

I see @jemc has a branch with the user-data: master...jemc:ase-parser:add/user-data - if that was rebased to lastest master would that be a good starting place for contributing the feature?

@zastrowm
Copy link

The rebase is available at master...zastrowm:ase-parser:master, though I did notice that the spec mentions more types of custom data (like property maps) that I don't need to use and thus isn't implemented.

@TheCyberRonin
Copy link
Owner Author

Let me get this set up for testing! Sorry, 2 kiddos under 2 is kicking my butt!

@TheCyberRonin
Copy link
Owner Author

@jemc if you want to submit a PR, I think the board is clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCyberRonin TheCyberRonin

Labels
enhancement New feature or request
Projects
Ase-parser Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zastrowm @jemc @TheCyberRonin