Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Dark mode should make the entire page dark #8

Open
sovoid opened this issue Jun 9, 2020 · 3 comments
Open

UI: Dark mode should make the entire page dark #8

sovoid opened this issue Jun 9, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@sovoid
Copy link
Contributor

sovoid commented Jun 9, 2020

On toggling dark mode, there seems to be a white strip on mobile view that doesnt turn dark. This needs to be fixed

@sovoid sovoid added the bug Something isn't working label Jun 9, 2020
@sovoid sovoid changed the title Dark mode should make the entire page dark UI: Dark mode should make the entire page dark Jun 9, 2020
@agarwalrounak
Copy link

I think this is related to #7. I haven't checked it on mobile but the reason should be the same.

@NidhiKJha
Copy link
Contributor

@agarwalrounak so there is a padding in the bottom that is left white even when the user toggles to the dark mode. So, this is kind of similar but a different issue. Here we want to get rid of this bottom white padding.

Screenshot from 2020-06-12 16-35-03

@NidhiKJha
Copy link
Contributor

NidhiKJha commented Jun 12, 2020

@Tanmayi03 You can start working on it. Let us know if you need any help.

Tanmayi03 added a commit to Tanmayi03/codesis-website that referenced this issue Jun 12, 2020
Tanmayi03 added a commit to Tanmayi03/codesis-website that referenced this issue Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants